Apologies for the noise, looks like I don't have a CONFIG_DEVICE_PRIVATE=n build in my tests and missed creating definitions for the new static inline functions for that configuration. I'll wait for some feedback on the overall approach and fix this in a v3. - Alistair On Friday, 19 February 2021 3:04:07 PM AEDT kernel test robot wrote: > External email: Use caution opening links or attachments > > > Hi Alistair, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on kselftest/next] > [also build test ERROR on linus/master v5.11 next-20210218] > [cannot apply to hnaz-linux-mm/master] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Alistair-Popple/Add-support-for-SVM-atomics-in-Nouveau/20210219-100858 > base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next > config: mips-randconfig-r036-20210218 (attached as .config) > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/ make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install mips cross compiling tool for clang build > # apt-get install binutils-mips-linux-gnu > # https://github.com/0day-ci/linux/commit/ bb5444811772d30b2e3bbaa44baeb8a4b3f03cec > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Alistair-Popple/Add-support-for- SVM-atomics-in-Nouveau/20210219-100858 > git checkout bb5444811772d30b2e3bbaa44baeb8a4b3f03cec > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All error/warnings (new ones prefixed by >>): > > >> fs/proc/task_mmu.c:521:12: error: implicit declaration of function 'is_device_exclusive_entry' [-Werror,-Wimplicit-function-declaration] > else if (is_device_exclusive_entry(swpent)) > ^ > fs/proc/task_mmu.c:521:12: note: did you mean 'is_device_private_entry'? > include/linux/swapops.h:176:20: note: 'is_device_private_entry' declared here > static inline bool is_device_private_entry(swp_entry_t entry) > ^ > >> fs/proc/task_mmu.c:522:11: error: implicit declaration of function 'device_exclusive_entry_to_page' [-Werror,-Wimplicit-function-declaration] > page = device_exclusive_entry_to_page(swpent); > ^ > fs/proc/task_mmu.c:522:11: note: did you mean 'device_private_entry_to_page'? > include/linux/swapops.h:191:28: note: 'device_private_entry_to_page' declared here > static inline struct page *device_private_entry_to_page(swp_entry_t entry) > ^ > >> fs/proc/task_mmu.c:522:9: warning: incompatible integer to pointer conversion assigning to 'struct page *' from 'int' [-Wint-conversion] > page = device_exclusive_entry_to_page(swpent); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > fs/proc/task_mmu.c:1395:7: error: implicit declaration of function 'is_device_exclusive_entry' [-Werror,-Wimplicit-function-declaration] > if (is_device_exclusive_entry(entry)) > ^ > fs/proc/task_mmu.c:1396:11: error: implicit declaration of function 'device_exclusive_entry_to_page' [-Werror,-Wimplicit-function-declaration] > page = device_exclusive_entry_to_page(entry); > ^ > fs/proc/task_mmu.c:1396:9: warning: incompatible integer to pointer conversion assigning to 'struct page *' from 'int' [-Wint-conversion] > page = device_exclusive_entry_to_page(entry); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2 warnings and 4 errors generated. > > > vim +/is_device_exclusive_entry +521 fs/proc/task_mmu.c > > 490 > 491 static void smaps_pte_entry(pte_t *pte, unsigned long addr, > 492 struct mm_walk *walk) > 493 { > 494 struct mem_size_stats *mss = walk->private; > 495 struct vm_area_struct *vma = walk->vma; > 496 bool locked = !!(vma->vm_flags & VM_LOCKED); > 497 struct page *page = NULL; > 498 > 499 if (pte_present(*pte)) { > 500 page = vm_normal_page(vma, addr, *pte); > 501 } else if (is_swap_pte(*pte)) { > 502 swp_entry_t swpent = pte_to_swp_entry(*pte); > 503 > 504 if (!non_swap_entry(swpent)) { > 505 int mapcount; > 506 > 507 mss->swap += PAGE_SIZE; > 508 mapcount = swp_swapcount(swpent); > 509 if (mapcount >= 2) { > 510 u64 pss_delta = (u64)PAGE_SIZE << PSS_SHIFT; > 511 > 512 do_div(pss_delta, mapcount); > 513 mss->swap_pss += pss_delta; > 514 } else { > 515 mss->swap_pss += (u64)PAGE_SIZE << PSS_SHIFT; > 516 } > 517 } else if (is_migration_entry(swpent)) > 518 page = migration_entry_to_page(swpent); > 519 else if (is_device_private_entry(swpent)) > 520 page = device_private_entry_to_page(swpent); > > 521 else if (is_device_exclusive_entry(swpent)) > > 522 page = device_exclusive_entry_to_page(swpent); > 523 } else if (unlikely(IS_ENABLED(CONFIG_SHMEM) && mss- >check_shmem_swap > 524 && pte_none(*pte))) { > 525 page = xa_load(&vma->vm_file->f_mapping->i_pages, > 526 linear_page_index(vma, addr)); > 527 if (xa_is_value(page)) > 528 mss->swap += PAGE_SIZE; > 529 return; > 530 } > 531 > 532 if (!page) > 533 return; > 534 > 535 smaps_account(mss, page, false, pte_young(*pte), pte_dirty(*pte), locked); > 536 } > 537 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
