* Peter Zijlstra <peterz@xxxxxxxxxxxxx> [2011-09-26 16:23:53]: > On Tue, 2011-09-20 at 17:33 +0530, Srikar Dronamraju wrote: > > +fail: > > + pr_warn_once("uprobes: Failed to adjust return address after" > > + " single-stepping call instruction;" > > + " pid=%d, sp=%#lx\n", current->pid, sp); > > + return -EFAULT; > > So how can that happen? Single-Step while someone unmapped the stack? We do a copy_to_user, copy_from_user just above this, Now if either of them fail, we have no choice but to Bail out. What caused this EFault may not be under Uprobes's Control. -- Thanks and Regards Srikar -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>