On Mon, Feb 15, 2021 at 10:32:57PM +0000, Matthew Wilcox wrote: > On Mon, Feb 15, 2021 at 11:47:40PM +0200, Mike Rapoport wrote: > > > /** > > > + * alloc_pages - Allocate pages. > > > + * @gfp: GFP flags. > > > + * @order: Power of two of number of pages to allocate. > > > * > > > + * Allocate 1 << @order contiguous pages. The physical address of the > > > + * first page is naturally aligned (eg an order-3 allocation will be aligned > > > + * to a multiple of 8 * PAGE_SIZE bytes). The NUMA policy of the current > > > + * process is honoured when in process context. > > > * > > > + * Context: Can be called from any context, providing the appropriate GFP > > > + * flags are used. > > > + * Return: NULL when no page can be allocated. > > > > Don't you want to mention the return value on success? It is quite obvious, > > but still. > > Sure. Preferred wording? > > + * Return: The page on success or NULL if allocation fails. Works for me :) -- Sincerely yours, Mike.
