Re: [linux-next:master 5178/10581] net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 12, 2021 at 3:04 PM Florian Westphal <fw@xxxxxxxxx> wrote:
>
> kernel test robot <lkp@xxxxxxxxx> wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   671176b0016c80b3943cb5387312c886aba3308d
> > commit: 83ace77f51175023c3757e2d08a92565f9b1c7f3 [5178/10581] netfilter: ctnetlink: remove get_ct indirection
>
> > >> net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here [-Wuninitialized]
> >            if (ct && nfnl_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0)
> >                                              ^~~~~~
> >    net/netfilter/nfnetlink_queue.c:391:2: note: variable 'ctinfo' is declared here
>
> Looks like a false positive.
>
> ctinfo is uninitialized only if ct == NULL.
>
> The config even has "CONFIG_NF_CONNTRACK is no set"
> so ct is always NULL.
>
> Could be "fixed" by adding aother ifdef but it would
> add even more clutter to an huge function.

Can you please just initialize the variable so that the tree can
continue to build free of this warning?
-- 
Thanks,
~Nick Desaulniers




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux