On 2/11/21 2:36 AM, David Hildenbrand wrote: > ^ > > Please create proper patch subjects. Nobody has a glue what you are doing when looking at the subject. > > "mm/util: fix ??? warning" > > Which raises the question, what is ??? > > Compiler? static code checker? ... ? > > > Thanks > > On 11.02.21 08:29, Adithya Chandrakasan wrote: >> FILE: mm/util.c:930: WARNING: Missing a blank line after declarations >> >> Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@xxxxxxxxx> >> --- >> mm/util.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/mm/util.c b/mm/util.c >> index 8c9b7d1e7c49..60286876636d 100644 >> --- a/mm/util.c >> +++ b/mm/util.c >> @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen) >> unsigned int len; >> struct mm_struct *mm = get_task_mm(task); >> unsigned long arg_start, arg_end, env_start, env_end; >> + >> if (!mm) >> goto out; >> if (!mm->arg_end) >> > > Hi David, Thanks for feedback. I have fixed the issues in the patch thread with change in subject and also log message. with regards, Adithya Chandrakasan
--- Begin Message ---
- To: akpm@xxxxxxxxxxxxxxxxxxxx
- Subject: [PATCH] Staging: mm: util.c: checkpatch.pl coding style warning fix
- From: Adithya Chandrakasan <adithya.chandrakasan@xxxxxxxxx>
- Date: Thu, 11 Feb 2021 09:59:14 -0800
- Cc: Adithya Chandrakasan <adithya.chandrakasan@xxxxxxxxx>, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, skhan@xxxxxxxxxxxxxxxxxxx, linux-kernel-mentees@xxxxxxxxxxxxxxxxxxxxxxxxx
- In-reply-to: <bce53689-4a6e-c3c3-a09c-6e946a577f61@redhat.com>
- References: <bce53689-4a6e-c3c3-a09c-6e946a577f61@redhat.com>
FILE: mm/util.c:930: checkpatch.pl scripts basic coding style issues as below WARNING: Missing a blank line after declarations Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@xxxxxxxxx> --- mm/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/util.c b/mm/util.c index 8c9b7d1e7c49..60286876636d 100644 --- a/mm/util.c +++ b/mm/util.c @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen) unsigned int len; struct mm_struct *mm = get_task_mm(task); unsigned long arg_start, arg_end, env_start, env_end; + if (!mm) goto out; if (!mm->arg_end) -- 2.25.1
--- End Message ---
