Re: [PATCH 1/3] mm/page_alloc: Fix pageblock_order when HUGETLB_PAGE_ORDER >= MAX_ORDER

To: Anshuman Khandual <anshuman.khandual@xxxxxxx>
Subject: Re: [PATCH 1/3] mm/page_alloc: Fix pageblock_order when HUGETLB_PAGE_ORDER >= MAX_ORDER
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 11 Feb 2021 09:00:56 +0100
Cc: linux-mm@xxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, catalin.marinas@xxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, will@xxxxxxxxxx, Robin Murphy <robin.murphy@xxxxxxx>, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1613024531-19040-2-git-send-email-anshuman.khandual@arm.com>
References: <1613024531-19040-1-git-send-email-anshuman.khandual@arm.com> <1613024531-19040-2-git-send-email-anshuman.khandual@arm.com>
User-agent: Mutt/1.5.17 (2007-11-01)

> -	if (HPAGE_SHIFT > PAGE_SHIFT)
> +	if ((HPAGE_SHIFT > PAGE_SHIFT) && (HUGETLB_PAGE_ORDER < MAX_ORDER))

No need for the braces.

Follow-Ups:
- Re: [PATCH 1/3] mm/page_alloc: Fix pageblock_order when HUGETLB_PAGE_ORDER >= MAX_ORDER
  - From: Anshuman Khandual

References:
- [PATCH 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE_VARIABLE
  - From: Anshuman Khandual
- [PATCH 1/3] mm/page_alloc: Fix pageblock_order when HUGETLB_PAGE_ORDER >= MAX_ORDER
  - From: Anshuman Khandual