On Tue, Feb 09, 2021 at 11:18:12AM -0600, George McCollister wrote: > On Tue, Feb 9, 2021 at 10:33 AM Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote: > > I think, this can defined under #ifdef CONFIG_OF. > > Was this robot reporting this warning for other DSA drivers? A lot of > them appear to use of_device_id in the same manner (unless I'm missing > something). Do we need to do something DSA wide to deal with this? Probably not DSA-wide since we still have drivers that probe on platform data and not OF (dsa_loop), but individual drivers should have "depends on OF" in Kconfig as far as I can tell.