Re: [PATCH v2] mm: cma: Print region name on failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09.02.21 15:24, Georgi Djakov wrote:
From: Patrick Daly <pdaly@xxxxxxxxxxxxxx>

Print the name of the CMA region for convenience. This is useful
information to have when cma_alloc() fails.

Signed-off-by: Patrick Daly <pdaly@xxxxxxxxxxxxxx>
Signed-off-by: Georgi Djakov <georgi.djakov@xxxxxxxxxx>
---
v2:
  * Print the "count" variable, as it was originally in the code. (Randy)
  * Fix spelling s/convienience/convenience/ in the commit text (Randy)

v1: https://lore.kernel.org/r/20210208115200.20286-1-georgi.djakov@xxxxxxxxxx/

  mm/cma.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/cma.c b/mm/cma.c
index 23d4a97c834a..54eee2119822 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -500,8 +500,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align,
  	}
if (ret && !no_warn) {
-		pr_err("%s: alloc failed, req-size: %zu pages, ret: %d\n",
-			__func__, count, ret);
+		pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n",
+		       __func__, cma->name, count, ret);
  		cma_debug_show_areas(cma);
  	}

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux