On Fri, Sep 23, 2011 at 6:45 AM, H Hartley Sweeten <hartleys@xxxxxxxxxxxxxxxxxxx> wrote: > Quite the sparse noise: > > warning: symbol 'swap_cgroup_ctrl' was not declared. Should it be static? > > Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> > Cc: Paul Menage <paul@xxxxxxxxxxxxxx> > Cc: Li Zefan <lizf@xxxxxxxxxxxxxx> > Cc: Balbir Singh <bsingharora@xxxxxxxxx> > Cc: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > > --- > > diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c > index 6bdc67d..eead840 100644 > --- a/mm/page_cgroup.c > +++ b/mm/page_cgroup.c > @@ -357,7 +357,7 @@ struct swap_cgroup_ctrl { > spinlock_t lock; > }; > > -struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES]; > +static struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES]; Seems reasonable Acked-by: Balbir Singh <bsingharora@xxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href