kernel test robot writes:
All errors (new ones prefixed by >>):
/usr/bin/ld: arch/um/drivers/xterm.o: in function `xterm_open':
xterm.c:(.text+0x16b): undefined reference to `printk'
/usr/bin/ld: xterm.c:(.text+0x1a8): undefined reference to `printk'
/usr/bin/ld: xterm.c:(.text+0x1f4): undefined reference to `printk'
/usr/bin/ld: xterm.c:(.text+0x25e): undefined reference to `printk'
/usr/bin/ld: xterm.c:(.text+0x2b5): undefined reference to `printk'
/usr/bin/ld: arch/um/drivers/xterm.o:xterm.c:(.text+0x31c): more undefined references to `printk' follow
collect2: error: ld returned 1 exit status
Ah yes, since it just uses it as extern. I'll fix it for v2.