On Fri, 5 Feb 2021 14:21:59 -0600 Seth Forshee <seth.forshee@xxxxxxxxxxxxx> wrote:
> Currently there seems to be an assumption in tmpfs that 64-bit
> architectures also have a 64-bit ino_t. This is not true; s390 at
> least has a 32-bit ino_t. With CONFIG_TMPFS_INODE64=y tmpfs
> mounts will get 64-bit inode numbers and display "inode64" in the
> mount options, but passing the "inode64" mount option will fail.
> This leads to the following behavior:
>
> # mkdir mnt
> # mount -t tmpfs nodev mnt
> # mount -o remount,rw mnt
> mount: /home/ubuntu/mnt: mount point not mounted or bad option.
>
> As mount sees "inode64" in the mount options and thus passes it
> in the options for the remount.
>
> Ideally CONFIG_TMPFS_INODE64 would depend on sizeof(ino_t) < 8,
> but I don't think it's possible to test for this (potentially
> CONFIG_ARCH_HAS_64BIT_INO_T or similar could be added, but I'm
> not sure whether or not that is wanted). So fix this by simply
> refusing to honor the CONFIG_TMPFS_INODE64 setting when
> sizeof(ino_t) < 8.
How about changing s390 Kconfig so that CONFIG_TMPFS_INODE64 is not enabled?
> Fixes: ea3271f7196c ("tmpfs: support 64-bit inums per-sb")
> Signed-off-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx>
With a cc:stable, I assume?
