Hello, On Thursday, September 08, 2011 7:27 PM Mike Frysinger wrote: > On Fri, Aug 19, 2011 at 10:27, Marek Szyprowski wrote: > > arch/arm/include/asm/device.h | 3 + > > arch/arm/include/asm/dma-contiguous.h | 33 +++ > > seems like these would be good asm-generic/ additions rather than arm Only some of them can be really moved to asm-generic imho. The following lines are definitely architecture specific: void dma_contiguous_early_fixup(phys_addr_t base, unsigned long size); Some other archs might define empty fixup function. Right now only ARM architecture is the real client of the CMA. IMHO if any other arch stats using CMA, some of the CMA definitions can be then moved to asm-generic. Right now I wanted to keep it as simple as possible. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>