On Sat, Jan 30, 2021 at 5:19 PM Nadav Amit <nadav.amit@xxxxxxxxx> wrote: > > > On Jan 30, 2021, at 5:02 PM, Andy Lutomirski <luto@xxxxxxxxxx> wrote: > > > > On Sat, Jan 30, 2021 at 4:16 PM Nadav Amit <nadav.amit@xxxxxxxxx> wrote: > >> From: Nadav Amit <namit@xxxxxxxxxx> > >> > >> fullmm in mmu_gather is supposed to indicate that the mm is torn-down > >> (e.g., on process exit) and can therefore allow certain optimizations. > >> However, tlb_finish_mmu() sets fullmm, when in fact it want to say that > >> the TLB should be fully flushed. > > > > Maybe also rename fullmm? > > Possible. How about mm_torn_down? Sure. Or mm_exiting, perhaps? > > I should have also changed the comment in tlb_finish_mmu().