On Thu, 28 Jan 2021 16:18:23 +0100 Vlastimil Babka <vbabka@xxxxxxx> wrote: > On 1/28/21 3:17 PM, Colin King wrote: > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > > > In the case where zpool_can_sleep_mapped(pool) returns 0 > > then tmp is not allocated and tmp is then an uninitialized > > pointer. Later if entry is null, tmp is freed, hence free'ing > > an uninitialized pointer. Fix this by ensuring tmp is initialized > > to NULL. > > > > Addresses-Coverity: ("Uninitialized pointer read") > > Fixes: 908aa806dba0 ("mm/zswap: fix potential memory leak") > > That's a linux-next hash, patch is in mmotm [1] *) You know what it means... > > *) actually it's not there, yet it is in -next. What's going on? > > [1] > https://ozlabs.org/~akpm/mmotm/broken-out/mm-zswap-fix-potential-memory-leak.patch The containing file was renamed to https://ozlabs.org/~akpm/mmotm/broken-out/mm-zswap-add-the-flag-can_sleep_mapped-fix-2.patch, since it's a fix against mm-zswap-add-the-flag-can_sleep_mapped.patch. And this patch's containing file will of course be mm-zswap-add-the-flag-can_sleep_mapped-fix-3.patch.