On Wed, Jan 27, 2021 at 10:25 PM Andrey Konovalov <andreyknvl@xxxxxxxxxx> wrote: > On Mon, Jan 25, 2021 at 12:28 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > > index de6b3f074742..32e7a5c148e6 100644 > > --- a/mm/kasan/shadow.c > > +++ b/mm/kasan/shadow.c > > @@ -94,6 +94,7 @@ void kasan_poison(const void *address, size_t size, u8 value) > > > > __memset(shadow_start, value, shadow_end - shadow_start); > > } > > +EXPORT_SYMBOL_GPL(kasan_poison); > > Should this be _GPL? All of the other EXPORT_SYMBOL() we use in KASAN > are without the GPL suffix. I don't care much either way, the reason I went for the _GPL variant was that this seems to only be used internally in mm/kasan/ and lib/test_kasan.c, unlike the other symbols that are meant to be called by other modules. Arnd