On Mon 19-09-11 15:23:44, Michal Hocko wrote: > On Mon 12-09-11 12:57:19, Johannes Weiner wrote: > > The traditional zone reclaim code is scanning the per-zone LRU lists > > during direct reclaim and kswapd, and the per-zone per-memory cgroup > > LRU lists when reclaiming on behalf of a memory cgroup limit. > > > > Subsequent patches will convert the traditional reclaim code to > > reclaim exclusively from the per-memory cgroup LRU lists. As a > > result, using the predicate for which LRU list is scanned will no > > longer be appropriate to tell global reclaim from limit reclaim. > > > > This patch adds a global_reclaim() predicate to tell direct/kswapd > > reclaim from memory cgroup limit reclaim and substitutes it in all > > places where currently scanning_global_lru() is used for that. > > I am wondering about vmscan_swappiness. Shouldn't it use global_reclaim > instead? Ahh, it looks like the next patch does that. Wouldn't it make more sense to have that change here? I see that this makes the patch smaller but... -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>