On 2021/1/23 6:05, Yu Zhao wrote: > These functions will call page_lru() in the following patches. Move > them below page_lru() to avoid the forward declaration. > > Link: https://lore.kernel.org/linux-mm/20201207220949.830352-3-yuzhao@xxxxxxxxxx/ > Signed-off-by: Yu Zhao <yuzhao@xxxxxxxxxx> Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> > --- > include/linux/mm_inline.h | 42 +++++++++++++++++++-------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h > index 8fc71e9d7bb0..2889741f450a 100644 > --- a/include/linux/mm_inline.h > +++ b/include/linux/mm_inline.h > @@ -45,27 +45,6 @@ static __always_inline void update_lru_size(struct lruvec *lruvec, > #endif > } > > -static __always_inline void add_page_to_lru_list(struct page *page, > - struct lruvec *lruvec, enum lru_list lru) > -{ > - update_lru_size(lruvec, lru, page_zonenum(page), thp_nr_pages(page)); > - list_add(&page->lru, &lruvec->lists[lru]); > -} > - > -static __always_inline void add_page_to_lru_list_tail(struct page *page, > - struct lruvec *lruvec, enum lru_list lru) > -{ > - update_lru_size(lruvec, lru, page_zonenum(page), thp_nr_pages(page)); > - list_add_tail(&page->lru, &lruvec->lists[lru]); > -} > - > -static __always_inline void del_page_from_lru_list(struct page *page, > - struct lruvec *lruvec, enum lru_list lru) > -{ > - list_del(&page->lru); > - update_lru_size(lruvec, lru, page_zonenum(page), -thp_nr_pages(page)); > -} > - > /** > * page_lru_base_type - which LRU list type should a page be on? > * @page: the page to test > @@ -125,4 +104,25 @@ static __always_inline enum lru_list page_lru(struct page *page) > } > return lru; > } > + > +static __always_inline void add_page_to_lru_list(struct page *page, > + struct lruvec *lruvec, enum lru_list lru) > +{ > + update_lru_size(lruvec, lru, page_zonenum(page), thp_nr_pages(page)); > + list_add(&page->lru, &lruvec->lists[lru]); > +} > + > +static __always_inline void add_page_to_lru_list_tail(struct page *page, > + struct lruvec *lruvec, enum lru_list lru) > +{ > + update_lru_size(lruvec, lru, page_zonenum(page), thp_nr_pages(page)); > + list_add_tail(&page->lru, &lruvec->lists[lru]); > +} > + > +static __always_inline void del_page_from_lru_list(struct page *page, > + struct lruvec *lruvec, enum lru_list lru) > +{ > + list_del(&page->lru); > + update_lru_size(lruvec, lru, page_zonenum(page), -thp_nr_pages(page)); > +} > #endif >