On Mon, Jan 25, 2021 at 05:31:14PM +0200, Mike Rapoport wrote:
> This would make sense but it's tricky. From memblock perspective,
> allocations are always allowed and it is the user responsibility to ensure
> all the early reservations are done before allocating memory.
Yah, I don't trust my users to know that for sure...
> So adding such a WARN would require a new memblock API and it's adoption by
> all architectures, which is way beyond the scope of this series :)
So definitely not for those series but I could imagine something like
memblock_reserve()
if (memblock_allocations_allowed())
WARN
or so. This way you don't need to touch the archtectures. It all depends
on what the other arches need/use.
Or you could even make that a new memblock_reserve_warn() thing or so
and wrap that functionality in it and have x86 call it only...
Anyway, something to that effect.
As to those two patches, you can add
Acked-by: Borislav Petkov <bp@xxxxxxx>
to the next revision since akpm is going to take them.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
