Re: [PATCH v4 15/18] mm/filemap: Restructure filemap_get_pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Subject: Re: [PATCH v4 15/18] mm/filemap: Restructure filemap_get_pages
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 21 Jan 2021 08:33:43 +0100
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, hch@xxxxxx, kent.overstreet@xxxxxxxxx
In-reply-to: <20210121041616.3955703-16-willy@infradead.org>
References: <20210121041616.3955703-1-willy@infradead.org> <20210121041616.3955703-16-willy@infradead.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Thu, Jan 21, 2021 at 04:16:13AM +0000, Matthew Wilcox (Oracle) wrote:
> Remove the got_pages label, remove indentation, rename find_page to retry,
> simplify error handling.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v4 00/18] Refactor generic_file_buffered_read
  - From: Matthew Wilcox (Oracle)
- [PATCH v4 15/18] mm/filemap: Restructure filemap_get_pages
  - From: Matthew Wilcox (Oracle)

Prev by Date: Re: [PATCH v4 14/18] mm/filemap: Split filemap_readahead out of filemap_get_pages
Next by Date: Re: [PATCH v4 16/18] mm/filemap: Don't relock the page after calling readpage
Previous by thread: [PATCH v4 15/18] mm/filemap: Restructure filemap_get_pages
Next by thread: [PATCH v4 16/18] mm/filemap: Don't relock the page after calling readpage
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux