CC Andrew On 1/18/21 3:07 AM, Miaohe Lin wrote: > When we reach here with inode = NULL, we should have crashed as inode has > already been dereferenced via hstate_inode. So this BUG_ON(!inode) does not > take effect and should be removed. > > Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> > --- > fs/hugetlbfs/inode.c | 2 -- > 1 file changed, 2 deletions(-) Thanks, Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> -- Mike Kravetz > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 016c863b493b..79464963f95e 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -759,8 +759,6 @@ static int hugetlbfs_setattr(struct dentry *dentry, struct iattr *attr) > unsigned int ia_valid = attr->ia_valid; > struct hugetlbfs_inode_info *info = HUGETLBFS_I(inode); > > - BUG_ON(!inode); > - > error = setattr_prepare(dentry, attr); > if (error) > return error; >
