Re: [PATCH v5 04/14] mm/gup: check for isolation errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jason Gunthorpe <jgg@xxxxxxxx>
Subject: Re: [PATCH v5 04/14] mm/gup: check for isolation errors
From: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
Date: Tue, 19 Jan 2021 13:27:45 -0500
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-mm <linux-mm@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Oscar Salvador <osalvador@xxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Sasha Levin <sashal@xxxxxxxxxx>, Tyler Hicks <tyhicks@xxxxxxxxxxxxxxxxxxx>, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>, mike.kravetz@xxxxxxxxxx, Steven Rostedt <rostedt@xxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, Linux Doc Mailing List <linux-doc@xxxxxxxxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, linux-kselftest@xxxxxxxxxxxxxxx
In-reply-to: <20210119182200.GZ4605@ziepe.ca>
References: <20210119043920.155044-1-pasha.tatashin@soleen.com> <20210119043920.155044-5-pasha.tatashin@soleen.com> <20210119182200.GZ4605@ziepe.ca>

> This should have a fixme too, this is a bug.

OK

>
> The patch looks OK, but I keep feeling this logic is all really
> overcomplicated...

I agree, I have a simplification patch for this logic, check out patch 12/14.

>
> Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Thank you for your review.

Pasha

References:
- [PATCH v5 00/14] prohibit pinning pages in ZONE_MOVABLE
  - From: Pavel Tatashin
- [PATCH v5 04/14] mm/gup: check for isolation errors
  - From: Pavel Tatashin
- Re: [PATCH v5 04/14] mm/gup: check for isolation errors
  - From: Jason Gunthorpe

Prev by Date: [PATCH v2] x86/vm86/32: Remove VM86_SCREEN_BITMAP support
Next by Date: Re: [PATCH v5 03/14] mm/gup: return an error on migration failure
Previous by thread: Re: [PATCH v5 04/14] mm/gup: check for isolation errors
Next by thread: [PATCH v5 05/14] mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_PIN
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]