> If you do use tracefs, add it to the top level tracing directory (no need > to have instances of it), and rename it to "kernel_warnings", as > "error_report" is too close to the existing "error_log" which holds error > messages of syntactic errors done by users entering in commands to some of > the special files. Will do. Is it conventional to add a new dentry* to struct trace_array for that? If not, maybe it's better to create this dir in error_report_notify_setup(), like this is done e.g. for /sys/kernel/tracing/trace_stat - just to loosen the coupling? > That is, /sys/kernel/tracing/kernel_warnings/ would be your error_report/ > directory you have now. WDYT about "kernel_errors" or "kernel_error_reports"? "warnings" suggest we'll be notifying about any occurrence of WARN(), which is not what we are planning to do. Also, shall I rename the library/config/etc. accordingly (to e.g. CONFIG_KERNEL_WARN_NOTIFY)? > Use the function in kernel/trace/trace.c: tracer_init_tracefs() to add that > directory. That's for files in the tracefs directory that will not be > duplicated by instances. > > -- Steve -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
