Re: [PATCH 4/9] hugetlb/userfaultfd: Unshare all pmds for hugetlbfs when register wp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Axel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on powerpc/next s390/features tip/perf/core linus/master v5.11-rc3 next-20210115]
[cannot apply to hp-parisc/for-next hnaz-linux-mm/master ia64/next sparc-next/master sparc/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Axel-Rasmussen/userfaultfd-add-minor-fault-handling/20210116-030900
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: microblaze-randconfig-r015-20210115 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/71aa60d93cd66a7587771bf19dd4313f7bb078c0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Axel-Rasmussen/userfaultfd-add-minor-fault-handling/20210116-030900
        git checkout 71aa60d93cd66a7587771bf19dd4313f7bb078c0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from fs/userfaultfd.c:30:
   fs/userfaultfd.c: In function 'hugetlb_unshare_all_pmds':
>> include/linux/hugetlb.h:967:49: error: implicit declaration of function 'flush_tlb_range'; did you mean 'flush_pmd_tlb_range'? [-Werror=implicit-function-declaration]
     967 | #define flush_hugetlb_tlb_range(vma, addr, end) flush_tlb_range(vma, addr, end)
         |                                                 ^~~~~~~~~~~~~~~
   fs/userfaultfd.c:1224:2: note: in expansion of macro 'flush_hugetlb_tlb_range'
    1224 |  flush_hugetlb_tlb_range(vma, vma->vm_start, vma->vm_end);
         |  ^~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +967 include/linux/hugetlb.h

97d3dcca13a550 Peter Xu 2021-01-15  961  
868bfaed893a49 Peter Xu 2021-01-15  962  #ifndef __HAVE_ARCH_FLUSH_HUGETLB_TLB_RANGE
868bfaed893a49 Peter Xu 2021-01-15  963  /*
868bfaed893a49 Peter Xu 2021-01-15  964   * ARCHes with special requirements for evicting HUGETLB backing TLB entries can
868bfaed893a49 Peter Xu 2021-01-15  965   * implement this.
868bfaed893a49 Peter Xu 2021-01-15  966   */
868bfaed893a49 Peter Xu 2021-01-15 @967  #define flush_hugetlb_tlb_range(vma, addr, end)	flush_tlb_range(vma, addr, end)
868bfaed893a49 Peter Xu 2021-01-15  968  #endif
868bfaed893a49 Peter Xu 2021-01-15  969  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux