On Tue, Sep 13, 2011 at 02:02:46AM +0300, Kirill A. Shutemov wrote: > On Mon, Sep 12, 2011 at 12:57:19PM +0200, Johannes Weiner wrote: > > @@ -1508,6 +1524,12 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone, > > if (scanning_global_lru(sc)) { > > nr_taken = isolate_pages_global(nr_to_scan, &page_list, > > &nr_scanned, sc->order, reclaim_mode, zone, 0, file); > > + } else { > > + nr_taken = mem_cgroup_isolate_pages(nr_to_scan, &page_list, > > + &nr_scanned, sc->order, reclaim_mode, zone, > > + sc->mem_cgroup, 0, file); > > + } > > Redundant braces. I usually keep them for multiline branches, no matter how any statements. But this is temporary anyway, 10/11 gets rid of this branch, leaving only nr_taken = isolate_pages(...) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>