On Wed, 2011-09-07 at 20:31 +0800, Wu Fengguang wrote:
> > > + x_intercept = min(write_bw, freerun);
> > > + if (bdi_dirty < x_intercept) {
> >
> > So the point of the freerun point is that we never throttle before it,
> > so basically all the below shouldn't be needed at all, right?
>
> Yes!
>
> > > + if (bdi_dirty > x_intercept / 8) {
> > > + pos_ratio *= x_intercept;
> > > + do_div(pos_ratio, bdi_dirty);
> > > + } else
> > > + pos_ratio *= 8;
> > > + }
> > > +
> > > return pos_ratio;
> > > }
Does that mean we can remove this whole block?
> >
> > So why not add:
> >
> > if (likely(dirty < freerun))
> > return 2;
> >
> > at the start of this function and leave it at that?
>
> Because we already has
>
> if (nr_dirty < freerun)
> break;
>
> in the main balance_dirty_pages() loop ;)
Bah! I keep missing that ;-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href