On 09/09/2011 04:34 PM, Greg KH wrote: > On Wed, Sep 07, 2011 at 09:09:04AM -0500, Seth Jennings wrote: >> Changelog: >> v2: fix bug in find_remove_block() >> fix whitespace warning at EOF >> >> This patchset introduces a new memory allocator for persistent >> pages for zcache. The current allocator is xvmalloc. xvmalloc >> has two notable limitations: >> * High (up to 50%) external fragmentation on allocation sets > PAGE_SIZE/2 >> * No compaction support which reduces page reclaimation > > I need some acks from other zcache developers before I can accept this. > First, thanks for this new allocator; xvmalloc badly needed a replacement :) I went through xcfmalloc in detail and would be posting detailed comments tomorrow. In general, it seems to be quite similar to the "chunk based" allocator used in initial implementation of "compcache" -- please see section 2.3.1 in this paper: http://www.linuxsymposium.org/archives/OLS/Reprints-2007/briglia-Reprint.pdf I'm really looking forward to a slab based allocator as I mentioned in the initial mail: http://permalink.gmane.org/gmane.linux.kernel.mm/65467 With the current design xcfmalloc suffers from issues similar to the allocator described in the paper: - High metadata overhead - Difficult implementation of compaction - Need for extra memcpy()s etc. With slab based approach, we can almost eliminate any metadata overhead, remove any free chunk merging logic, simplify compaction and so on. Thanks, Nitin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>