On 12.01.21 08:26, Oscar Salvador wrote: > On Mon, Jan 11, 2021 at 05:52:19PM +0100, David Hildenbrand wrote: >> On 17.12.20 14:07, Oscar Salvador wrote: >>> In order to use self-hosted memmap array, the platform needs to have >>> support for CONFIG_SPARSEMEM_VMEMMAP and altmap. >>> Currently, only arm64, PPC and x86_64 have the support, so enable those >>> platforms with ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE. >> >> "In the first version, only .... will support it". > > I will try to be more specific. > >> >> I'd probably split off enabling it per architecture in separate patches >> and the end of the series. > > You mean introducing only mm/Kconfig change in this patch, and then > arch/*/Kconfig changes in separate patches at the end of the series? Yeah, or squashing the leftovers of this patch (3 LOC) into patch #2. > > I can certainly do that, not sure how much will help with the review, > but it might help when bisecting. It's usually nicer to explicitly enable stuff per architecture, stating why it works on that architecture (and in the best case, even was tested!). :) -- Thanks, David / dhildenb
