Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Hildenbrand <david@xxxxxxxxxx>
Subject: Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform
From: Oscar Salvador <osalvador@xxxxxxx>
Date: Mon, 11 Jan 2021 14:43:08 +0100
Cc: Anshuman Khandual <anshuman.khandual@xxxxxxx>, linux-mm@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, hca@xxxxxxxxxxxxx, catalin.marinas@xxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Ard Biesheuvel <ardb@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>
In-reply-to: <10e733fa-4568-d38f-9b95-2ccc5dc627b8@redhat.com>
References: <1608218912-28932-1-git-send-email-anshuman.khandual@arm.com> <1608218912-28932-2-git-send-email-anshuman.khandual@arm.com> <10e733fa-4568-d38f-9b95-2ccc5dc627b8@redhat.com>
User-agent: Mutt/1.10.1 (2018-07-13)

On Mon, Jan 11, 2021 at 11:51:47AM +0100, David Hildenbrand wrote:
> AFAIKs, all memhp_get_pluggable_range() users pass "1".
> 
> What about the "add_pages()-only" path?

I guess you refer to memremap_pages(), right?
If so, moving the added memhp_range_allowed() check above the if-else might do
the trick

-- 
Oscar Salvador
SUSE L3

Follow-Ups:
- Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform
  - From: Anshuman Khandual

References:
- [PATCH V2 0/3] mm/hotplug: Pre-validate the address range with platform
  - From: Anshuman Khandual
- [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform
  - From: Anshuman Khandual
- Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform
  - From: David Hildenbrand

Prev by Date: Re: [PATCH v2 0/3] Create 'old' ptes for faultaround mappings on arm64 with hardware access flag
Next by Date: Re: [PATCH v2 0/3] Create 'old' ptes for faultaround mappings on arm64 with hardware access flag
Previous by thread: Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform
Next by thread: Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]