On Thu, 8 Sep 2011 08:50:11 -0700 (PDT) Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> wrote: > > From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx] > > Sent: Wednesday, September 07, 2011 5:27 PM > > To: Dan Magenheimer > > Subject: Re: [PATCH V8 3/4] mm: frontswap: add swap hooks and extend try_to_unuse > > > > On Mon, 29 Aug 2011 09:49:29 -0700 > > Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> wrote: > > > > > -static int try_to_unuse(unsigned int type) > > > +int try_to_unuse(unsigned int type, bool frontswap, > > > > Are patches 2 and 3 in the wrong order? > > No, they've applied in that order and built after each patch > properly for well over a year. At a minimum, frontswap.h must > be created before patch 3of4, though I suppose the introduction > of frontswap.c could be after patch 3of4... Note that frontswap.c > (which calls try_to_unuse()) is non-functional (and isn't even built) > until after patch 4of4 is applied. > > There is enough interdependency between the four parts > that perhaps it should all be a single commit. I split > it up for reviewer's convenience but apparently different > reviewers use different review processes than I anticipated. :-} > IIRC, I said 'please move this change of line to patch 1'. Thanks, -Kame This was my 1st reply. > > From: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> > > Subject: [PATCH V7 1/4] mm: frontswap: swap data structure changes > > > > This first patch of four in the frontswap series makes available core > > swap data structures (swap_lock, swap_list and swap_info) that are > > needed by frontswap.c but we don't need to expose them to the dozens > > of files that include swap.h so we create a new swapfile.h just to > > extern-ify these. > > > > Also add frontswap-related elements to swap_info_struct. Frontswap_map > > points to vzalloc'ed one-bit-per-swap-page metadata that indicates > > whether the swap page is in frontswap or in the device and frontswap_pages > > counts how many pages are in frontswap. > > > > [v7: rebase to 3.0-rc3] > > [v7: JBeulich@xxxxxxxxxx: add new swap struct elements only if config'd] > > [v6: rebase to 3.0-rc1] > > [v5: no change from v4] > > [v4: rebase to 2.6.39] > > Signed-off-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> > > Reviewed-by: Konrad Wilk <konrad.wilk@xxxxxxxxxx> > > Acked-by: Jan Beulich <JBeulich@xxxxxxxxxx> > > Acked-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx> > > Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx> > > Cc: Hugh Dickins <hughd@xxxxxxxxxx> > > Cc: Johannes Weiner <hannes@xxxxxxxxxxx> > > Cc: Nitin Gupta <ngupta@xxxxxxxxxx> > > Cc: Matthew Wilcox <matthew@xxxxxx> > > Cc: Chris Mason <chris.mason@xxxxxxxxxx> > > Cc: Rik Riel <riel@xxxxxxxxxx> > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > Hmm....could you modify mm/swapfile.c and remove 'static' in the same patch ? > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>