Re: [PATCH] slub: code optimze in get_partial_node()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 7 Sep 2011, Alex,Shi wrote:

> I find a way to reduce a variable in get_partial_node(). That is also
> helpful for code understanding. :)
>
> This patch base on 'slub/partial' head of penberg's tree.

Acked-by: Christoph Lameter <cl@xxxxxxxxx>

>
> Signed-off-by: Alex Shi <alex.shi@xxxxxxxxx>
> ---
>  mm/slub.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index ebb3865..8f68757 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1600,7 +1600,6 @@ static void *get_partial_node(struct kmem_cache *s,
>  {
>  	struct page *page, *page2;
>  	void *object = NULL;
> -	int count = 0;
>
>  	/*
>  	 * Racy check. If we mistakenly see no partial slabs then we
> @@ -1613,17 +1612,16 @@ static void *get_partial_node(struct kmem_cache *s,
>
>  	spin_lock(&n->list_lock);
>  	list_for_each_entry_safe(page, page2, &n->partial, lru) {
> -		void *t = acquire_slab(s, n, page, count == 0);
> +		void *t = acquire_slab(s, n, page, object == NULL);
>  		int available;
>
>  		if (!t)
>  			break;
>
> -		if (!count) {
> +		if (!object) {
>  			c->page = page;
>  			c->node = page_to_nid(page);
>  			stat(s, ALLOC_FROM_PARTIAL);
> -			count++;
>  			object = t;
>  			available =  page->objects - page->inuse;
>  		} else {
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]