Hi, Matthew: On Wed, Dec 30, 2020 at 12:42:33PM +0000, Matthew Wilcox wrote: > On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote: > > local variable node_order do not need the static here. > > It bloody well does. It can be up to 2^10 entries on x86 (and larger > on others) That's 4kB which you've now moved onto the stack. > Thanks for your explanation, this change will put too much onto the stack in some cases which i didn't consider. Please ignore this change. > Please, learn more about what you're doing. I suggest sending patches > to drivers/staging; that will help you learn how to submit patches to > linux.
