On Tue, Sep 6, 2011 at 9:23 PM, Glauber Costa <glommer@xxxxxxxxxxxxx> wrote:
> +
> +struct kmem_cgroup {
> + struct cgroup_subsys_state css;
> + struct kmem_cgroup *parent;
> +};
There's a parent pointer in css.cgroup, so you shouldn't need a
separate one here.
Most cgroup subsystems define this structure (and the below accessor
functions) in their .c file rather than exposing it to the world? Does
this subsystem particularly need it exposed?
> +
> +static struct cgroup_subsys_state *kmem_create(
> + struct cgroup_subsys *ss, struct cgroup *cgrp)
> +{
> + struct kmem_cgroup *sk = kzalloc(sizeof(*sk), GFP_KERNEL);
kcg or just cg would be a better name?
Paul
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href