Jacob Wen writes:
set_task_reclaim_state() is a function with 3 lines of code of which 2 lines contain WARN_ON_ONCE.I am not comfortable with the current repetition.
Ok, but could you please go into _why_ others should feel that way too? There are equally also reasons to err on the side of leaving code as-is -- since we know it already works, and this code generally has pretty high inertia -- and avoid mutation of code without concrete description of the benefits.