On 12/8/20 12:19 AM, Zaslonko Mikhail wrote: > > > On 08.12.2020 01:45, Randy Dunlap wrote: >> On 12/7/20 1:03 AM, Zaslonko Mikhail wrote: >>> Hello, >>> >>> should we probably put these to lib/zlib_dfltcc/dfltcc_syms.c along with the other EXPORT_SYMBOL statements? >> >> Hi, >> I didn't know about that file. :) >> >> That change makes sense. At least that's how some modules used >> to do it. Not so much nowadays, but this one might as well >> consistent within itself. >> >> Do you want to fix it or should I? > > Please, go ahead. > > Thanks. Hi, How do you feel about eliminating the dfltcc_syms.c file and putting the EXPORT_SYMBOL()s in the source file(s) where they occur? as expressed in coding-style.rst: In source files, separate functions with one blank line. If the function is exported, the **EXPORT** macro for it should follow immediately after the closing function brace line. (also move the MODULE_LICENSE() to a different source file.) >> >> Thanks. >> >>> Reviewed-by: Mikhail Zaslonko <zaslonko@xxxxxxxxxxxxx> >>> >>> On 06.12.2020 07:14, Andrew Morton wrote: >>>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >>>> Subject: zlib: export S390 symbols for zlib modules >>>> >>>> Fix build errors when ZLIB_INFLATE=m and ZLIB_DEFLATE=m and ZLIB_DFLTCC=y >>>> by exporting the 2 needed symbols in dfltcc_inflate.c. thanks. -- ~Randy
