On Fri, 18 Dec 2020 18:32:49 +0800 hui yang <yanghui.def@xxxxxxxxx> wrote:
> From: YangHui <yanghui.def@xxxxxxxxx>
>
> make code more formal.
>
> ...
>
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2425,7 +2425,7 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
> {
> unsigned long nr[NR_LRU_LISTS];
> unsigned long targets[NR_LRU_LISTS];
> - unsigned long nr_to_scan;
> + unsigned long nr_to_scan, scan_target;
> enum lru_list lru;
> unsigned long nr_reclaimed = 0;
> unsigned long nr_to_reclaim = sc->nr_to_reclaim;
> @@ -2492,12 +2492,12 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
> break;
>
> if (nr_file > nr_anon) {
> - unsigned long scan_target = targets[LRU_INACTIVE_ANON] +
> + scan_target = targets[LRU_INACTIVE_ANON] +
> targets[LRU_ACTIVE_ANON] + 1;
> lru = LRU_BASE;
> percentage = nr_anon * 100 / scan_target;
> } else {
> - unsigned long scan_target = targets[LRU_INACTIVE_FILE] +
> + scan_target = targets[LRU_INACTIVE_FILE] +
> targets[LRU_ACTIVE_FILE] + 1;
> lru = LRU_FILE;
> percentage = nr_file * 100 / scan_target;
I tend to prefer the original code - this change gives scan_target
function-wide scope, which it does not need. Makes it harder for the
reader to understand where and why this variable is used.
