On Thu, Dec 17, 2020 at 7:53 AM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Thu, Dec 17, 2020 at 10:03:11AM +0800, Xiangyang Yu wrote: > > Fixed the warning when building with warnings enabled (W=1), > > This function is only used in filemap.c, so mark this function > > with 'static'. > > Good grief, no. Look at the git history before proposing a patch. revert "mm/filemap: add static for function __add_to_page_cache_locked" Revert commit 3351b16af494 ("mm/filemap: add static for function __add_to_page_cache_locked") due to incompatibility with ALLOW_ERROR_INJECTION which result in build errors. >