On Wed, Dec 09, 2020 at 05:53:06PM +0000, Christoph Hellwig wrote: > On Wed, Dec 09, 2020 at 06:57:02AM -0800, Paul E. McKenney wrote: > > On Wed, Dec 09, 2020 at 08:17:10AM +0000, Christoph Hellwig wrote: > > > Your two new exports don't actually seem to get used in modular code > > > at all in this series. > > > > Indeed, and I either need to remove the exports or make my test code in > > kernel/rcu/rcuscale.o suitable for upstreaming. Or find the appropriate > > mm/slab selftest location. > > I'd rather not export something like this which pokes deep into > internals. That being said I've been working on off on a > EXPORT_SYMBOL_FOR() that just exports a symbol to one specific module. > Hopefully I'll finish it for the next merge window, and with that > I'd feel much more comfortable with an export. That would be really useful! I have a number of symbols that should only be used by a few specific in-tree modules, independent of this patch series. For my part, I will see if there is a good mm-related location for this sort of selftest. Thanx, Paul