Re: [PATCH] z3fold: stricter locking and more careful reclaim

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2020-12-05 at 12:38 +0100, Vitaly Wool wrote:
> On Fri, Dec 4, 2020 at 10:47 PM Mike Galbraith <efault@xxxxxx> wrote:
> >
> > On Fri, 2020-12-04 at 22:04 +0200, Vitaly Wool wrote:
> > > Use temporary slots in reclaim function to avoid possible race when
> > > freeing those.
> > >
> > > While at it, make sure we check CLAIMED flag under page lock in the
> > > reclaim function to make sure we are not racing with z3fold_alloc().
> > >
> > > Signed-off-by: Vitaly Wool <vitaly.wool@xxxxxxxxxxxx>
> >
> > FYI, with this applied, ltp::mm still crashes the RT kernel, with the
> > same rwlock corruption being what takes it down.
>
> So sad it does, but thanks a lot for the quick response.

Thanks for taking a poke at it.  Intuitive switch to write_lock() in
__release_z3fold_page() "fixed" the darn thing, but staring at it since
has yet to inspire a clear "and that works because...".

	-Mike






[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux