On Wed, Nov 25, 2020 at 10:27:49AM +0100, Jean-Philippe Brucker wrote: > > I'm strongly > > trying to discourage static lists matching mm's like smmu_mn is > > doing. This is handled by the core code, don't open code it.. > > We discussed this at v6, which wonkily stored the mn ops in the domain to > obtain a unique notifier per {mm, domain}. A clean solution requires > changing mm_notifier_get() to use an opaque token. Rather than testing > {mm, ops} uniqueness it would compare {mm, ops, token}. I figured it > wasn't worth the effort for a single driver, especially since the SMMU > driver would still have one list matching because it needs to deal with > both {mm, domain} and {mm, device} uniqueness. > https://lore.kernel.org/linux-iommu/20200501121552.GA6012@xxxxxxxxxxxxx/ Oh, that was a long time ago.. OK Thanks, Jason