On Tue, 24 Nov 2020 12:21:28 +0100 Vlastimil Babka <vbabka@xxxxxxx> wrote: > On 11/22/20 3:00 PM, Alex Shi wrote: > > Thanks a lot for all comments, I picked all up and here is the v3: > > > > From 167131dd106a96fd08af725df850e0da6ec899af Mon Sep 17 00:00:00 2001 > > From: Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx> > > Date: Fri, 20 Nov 2020 14:49:16 +0800 > > Subject: [PATCH v3 next] mm/vmscan: __isolate_lru_page_prepare clean up > > > > The function just return 2 results, so use a 'switch' to deal with its > > result is unnecessary, and simplify it to a bool func as Vlastimil > > suggested. > > > > Also remove 'goto' by reusing list_move(), and take Matthew Wilcox's > > suggestion to update comments in function. > > I wouldn't mind if the goto stayed, but it's not repeating that much > without it (list_move() + continue, 3 times) so... I tried that, and .text became significantly larger, for reasons which I didn't investigate ;)
