Re: [PATCH 5/6] tlb: mmu_gather: Introduce tlb_gather_mmu_fullmm()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 5/6] tlb: mmu_gather: Introduce tlb_gather_mmu_fullmm()
From: Will Deacon <will@xxxxxxxxxx>
Date: Mon, 23 Nov 2020 16:48:11 +0000
Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Android Kernel Team <kernel-team@xxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Yu Zhao <yuzhao@xxxxxxxxxx>, Minchan Kim <minchan@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Anshuman Khandual <anshuman.khandual@xxxxxxx>, Linux-MM <linux-mm@xxxxxxxxx>, Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <CAHk-=wjQWa14_4UpfDf=fiineNP+RH74kZeDMo_f1D35xNzq9w@mail.gmail.com>
References: <20201120143557.6715-1-will@kernel.org> <20201120143557.6715-6-will@kernel.org> <CAHk-=wghWFQCW83Xr16C3q+y5xZNM9frH4V9AqauedMEJ1V4wQ@mail.gmail.com> <CAHk-=wjQWa14_4UpfDf=fiineNP+RH74kZeDMo_f1D35xNzq9w@mail.gmail.com>
User-agent: Mutt/1.10.1 (2018-07-13)

On Fri, Nov 20, 2020 at 09:31:09AM -0800, Linus Torvalds wrote:
> Oh - wait.
> 
> Not ack.
> 
> Not because this is wrong, but because I think you should remove the
> start/end arguments here too.
> 
> The _only_ thing they were used for was that "fullmm" flag, afaik. So
> now they no longer make sense.
> 
> Hmm?

Oh nice, well spotted. I'll drop them for v2.

Cheers,

Will

References:
- [PATCH 0/6] tlb: Fix access and (soft-)dirty bit management
  - From: Will Deacon
- [PATCH 5/6] tlb: mmu_gather: Introduce tlb_gather_mmu_fullmm()
  - From: Will Deacon
- Re: [PATCH 5/6] tlb: mmu_gather: Introduce tlb_gather_mmu_fullmm()
  - From: Linus Torvalds
- Re: [PATCH 5/6] tlb: mmu_gather: Introduce tlb_gather_mmu_fullmm()
  - From: Linus Torvalds

Prev by Date: Re: [PATCH] kfence: Avoid stalling work queue task without allocations
Next by Date: Re: [PATCH 3/6] tlb: mmu_gather: Remove unused start/end arguments from tlb_finish_mmu()
Previous by thread: Re: [PATCH 5/6] tlb: mmu_gather: Introduce tlb_gather_mmu_fullmm()
Next by thread: [tlb] e242a269fa: WARNING:at_mm/mmu_gather.c:#tlb_gather_mmu
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]