On Tue, Nov 17, 2020 at 2:25 PM Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote: > > On Fri, Nov 13, 2020 at 11:20 PM Andrey Konovalov <andreyknvl@xxxxxxxxxx> wrote: > > > > The reason cache merging is disabled with KASAN is because KASAN puts its > > metadata right after the allocated object. When the merged caches have > > slightly different sizes, the metadata ends up in different places, which > > KASAN doesn't support. > > > > It might be possible to adjust the metadata allocation algorithm and make > > it friendly to the cache merging code. Instead this change takes a simpler > > approach and allows merging caches when no metadata is present. Which is > > the case for hardware tag-based KASAN with kasan.mode=prod. > > > > Co-developed-by: Vincenzo Frascino <Vincenzo.Frascino@xxxxxxx> > > Signed-off-by: Vincenzo Frascino <Vincenzo.Frascino@xxxxxxx> > > Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > > Link: https://linux-review.googlesource.com/id/Ia114847dfb2244f297d2cb82d592bf6a07455dba > > Somehow gerrit contains an old version... so I was going to > independently propose what Marco already proposed as simplification... > until I looked at the patch in the email :) Ah, this is because I couldn't push next/mm-based changes into Gerrit without manually adding tags to all of the yet-out-of-tree patches. So the Gerrit doesn't have the last version of the patchset. > Reviewed-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx> Thanks!