On 21.11.20 20:53, Andrea Arcangeli wrote: > On Sat, Nov 21, 2020 at 02:45:06PM -0500, Andrea Arcangeli wrote: >> + if (likely(!PageReserved(page))) > > NOTE: this line will have to become "likely(page && > !PageReserved(page))" to handle the case of non contiguous zones, > since pageblock_pfn_to_page might return NULL in that case.. I noticed > right after sending, but I'll wait some feedback before resending the > correction in case it gets fixed in another way. With that fixed, this looks sane to me. -- Thanks, David / dhildenb