On Thu, Nov 19, 2020 at 09:25:05AM +0100, Jan Kara wrote: > OK, understood. Still it would seem more logical to leave blk_lookup_devt() > declaration inside #ifdef CONFIG_BLOCK and just delete the !CONFIG_BLOCK > definition (to make it clear we ever expect only users compiled when > CONFIG_BLOCK is defined). But whatever... Feel free to add: Not having the ifdef would allow using IS_ENABLED() around it. Which is what I did in one of the earlier variants before settlings on this one.