On Thu, 25 Aug 2011 11:31:45 +0800 Cong Wang wrote: > 于 2011年08月25日 10:14, Randy Dunlap 写道: > > On Wed, 24 Aug 2011 11:34:45 +0800 Cong Wang wrote: > > > >> Hi, Andrew, > >> > >> Do you think my patch below is better? > > > > Hi, > > > > This causes build errors for me because node.o is not being built: > > > > arch/x86/built-in.o: In function `topology_init': > > topology.c:(.init.text+0x3668): undefined reference to `register_one_node' > > drivers/built-in.o: In function `unregister_cpu': > > (.text+0x7aecc): undefined reference to `unregister_cpu_under_node' > > drivers/built-in.o: In function `register_cpu': > > (.cpuinit.text+0xc1): undefined reference to `register_cpu_under_node' > > Ah, this is because I missed the part in include/linux/node.h. :) > > Below is the updated version. > > Thanks for testing! Yes, that works after changing #ifdef defined(...) to #if defined(...) Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx> --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>