On Thu, Nov 12, 2020 at 09:26:29PM +0000, Matthew Wilcox (Oracle) wrote: > The functionality of find_lock_entry() and find_get_entry() can be > provided by pagecache_get_pages(), s/pagecache_get_pages/pagecache_get_page/ > which lets us delete find_lock_entry() > and make find_get_entry() static. I think this should mention that find_get_entry is now only used by pagecache_get_page. That answers the obvious questions of why we could not switch all callers of find_get_entry to pagecache_get_page. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
