On Thu, Nov 12, 2020 at 8:52 PM Marco Elver <elver@xxxxxxxxxx> wrote: > > On Thu, 12 Nov 2020 at 20:45, Andrey Konovalov <andreyknvl@xxxxxxxxxx> wrote: > > > > On Wed, Nov 11, 2020 at 6:49 PM Marco Elver <elver@xxxxxxxxxx> wrote: > > > > > > On Tue, Nov 10, 2020 at 11:20PM +0100, Andrey Konovalov wrote: > > > > Currently kasan_unpoison_memory() is used as both an external annotation > > > > and as an internal memory poisoning helper. Rename external annotation to > > > > kasan_unpoison_data() and inline the internal helper for hardware > > > > tag-based mode to avoid undeeded function calls. > > > > > > I don't understand why this needs to be renamed again. The users of > > > kasan_unpoison_memory() outweigh those of kasan_unpoison_slab(), of > > > which there seems to be only 1! > > > > The idea is to make kasan_(un)poison_memory() functions inlinable for > > internal use. It doesn't have anything to do with the number of times > > they are used. > > > > Perhaps we can drop the kasan_ prefix for the internal implementations > > though, and keep using kasan_unpoison_memory() externally. > > Whatever avoids changing the external interface, because it seems > really pointless. I can see why it's done, but it's a side-effect of > the various wrappers being added. It looks like unposion_memory() is already taken. Any suggestions for internal KASAN poisoning function names?
