On Wed, Nov 11, 2020 at 3:40 AM Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote: > > On 11/9/20 6:42 PM, Muchun Song wrote: > > On Tue, Nov 10, 2020 at 12:48 AM Oscar Salvador <osalvador@xxxxxxx> wrote: > >> > >> On Sun, Nov 08, 2020 at 10:10:56PM +0800, Muchun Song wrote: > >> > >> Unrelated to this patch but related in general, I am not sure about Mike but > >> would it be cleaner to move all the vmemmap functions to hugetlb_vmemmap.c? > >> hugetlb code is quite tricky, so I am not sure about stuffing more code > >> in there. > >> > > > > I also think that you are right, moving all the vmemmap functions to > > hugetlb_vmemmap.c may make the code cleaner. > > > > Hi Mike, what's your opinion? > > I would be happy to see this in a separate file. As Oscar mentions, the > hugetlb.c file/code is already somethat difficult to read and understand. Got it. I will do this. Thanks. > -- > Mike Kravetz -- Yours, Muchun
