On 11/8/20 11:45 PM, John Hubbard wrote: > On 11/8/20 12:37 AM, Barry Song wrote: >> Without DEBUG_FS, all the code in gup_test becomes meaningless. For sure >> kernel provides debugfs stub while DEBUG_FS is disabled, but the point >> here is that GUP_TEST can do nothing without DEBUG_FS. >> >> Cc: John Hubbard <jhubbard@xxxxxxxxxx> >> Cc: Ralph Campbell <rcampbell@xxxxxxxxxx> >> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> Suggested-by: John Garry <john.garry@xxxxxxxxxx> >> Signed-off-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx> >> --- >> -v2: >> add comment as a prompt to users as commented by John and Randy, thanks! >> >> mm/Kconfig | 4 ++++ >> 1 file changed, 4 insertions(+) > > Thanks for suffering through a lot of discussion about this! > > Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx> > > > thanks, Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> thanks. -- ~Randy