On Fri, Nov 06, 2020 at 12:46:47PM -0800, Randy Dunlap wrote: > Hi, > > Fix a few typos: > > On 11/6/20 12:32 PM, Minchan Kim wrote: > > --- > > Documentation/admin-guide/sysctl/vm.rst | 14 ++++++++++++++ > > include/linux/mm.h | 2 ++ > > include/linux/oom.h | 1 + > > kernel/sysctl.c | 9 +++++++++ > > mm/oom_kill.c | 24 ++++++++++++++++++++++++ > > 5 files changed, 50 insertions(+) > > > > diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst > > index f455fa00c00f..49dcedfaf0c0 100644 > > --- a/Documentation/admin-guide/sysctl/vm.rst > > +++ b/Documentation/admin-guide/sysctl/vm.rst > > @@ -694,6 +694,20 @@ is used in oom_kill_allocating_task. > > > > The default value is 0. > > > > +oom_kill_disable > > +================ > > + > > +This disables or enables OOM killing in out-of-memory situations. > > + > > +If this is set to one, the OOM killer is disabled so OOM kill never > > +hapens in out-of-memory situation. It could cause system dangerous > > happens It could cause a dangerous system > > > +state due to memory allocation failure so user should be careful to > > careful when > > +use it. > > using it. > > > + > > +If this is set to zero, the OOM killer is enabled so OOM kill happens > > +in out-of-memory situations. > > + > > +The default value is 0. > > > > overcommit_kbytes > > ================= > > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > > index 8b84661a6410..0f48cdeeb1e7 100644 > > --- a/mm/oom_kill.c > > +++ b/mm/oom_kill.c > > > #ifdef CONFIG_NUMA > > /** > > * oom_cpuset_eligible() - check task eligiblity for kill > > eligibility > > but that's not in your patch, so don't bother with it. :) Sure, I will resend it with fixing after waiting some feedback. Thanks for the review, Randy.